mark/expression: some cleanups in preparation for possibly exposing publicly #13790
+100
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should do it properly, not a big difference.
Make the module a little nicer ahead of possibly exposing it publicly.
If we are going to expose Expression, better to use a general exception, this way we can avoid exposing an extra type.
bluetech
force-pushed
the
expression-lipstick
branch
from
7ab0232 to
d77cbfa
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13783 (comment) suggests we might want to expose
Expression. This PR makes some small changes in preparation of that from going over the code. Please see the commits.